Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd compaction during watch util retry could cause error #61

Closed
Revolution1 opened this issue Feb 26, 2019 · 1 comment · Fixed by #82
Closed

etcd compaction during watch util retry could cause error #61

Revolution1 opened this issue Feb 26, 2019 · 1 comment · Fixed by #82
Assignees
@Revolution1
Labels
bug Something isn't working Priority: Critical

Comments

@Revolution1
Copy link
Owner

Revolution1 commented Feb 26, 2019 •
edited
Loading

if:

watcher failed -> etcd revision compacted -> watcher retry

the watcher will block forever!!!!!
@Revolution1 Revolution1 added the bug Something isn't working label Feb 26, 2019
@Revolution1 Revolution1 self-assigned this Feb 26, 2019
@Revolution1
Copy link
Owner Author

in etcd3/stateful/watch.py:355

etcdserverpbWatchResponse(header=etcdserverpbResponseHeader(cluster_id=7618600686883421296, member_id=11759754502496582951, revision=21, raft_term=2), created=True)

etcdserverpbWatchResponse(header=etcdserverpbResponseHeader(cluster_id=7618600686883421296, member_id=11759754502496582951, raft_term=2), canceled=True, compact_revision=19)

@Revolution1 Revolution1 mentioned this issue Feb 27, 2019
Closed
Revolution1 added a commit that referenced this issue Apr 16, 2019
@Revolution1
fix #61 handle watch cancel
ecd8a0a
@Revolution1 Revolution1 mentioned this issue Apr 16, 2019
Merged
Revolution1 added a commit that referenced this issue Apr 17, 2019
@Revolution1
Fix watch util issue 18 and 78 (#82)
2262636 
* fix issue #78
add header to watch-event

Signed-off-by: Renjie Cai <crj93106@gmail.com>

* fix #61 handle watch cancel

* add unit test for compaction related

* pytest version

* fix test

* fix test

* cov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Revolution1 Revolution1

Labels
bug Something isn't working Priority: Critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix watch util issue 18 and 78 Revolution1/etcd3-py
1 participant
@Revolution1