-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MessageGeneration from ros-sharp #56
Conversation
- Somewhat simplified/modernized to .NET 6 - Gives a scaffold to expand for our requirement of binary serialization
this._builtInTypesDefaultInitialValues = builtInTypesDefaultInitialValues; | ||
} | ||
|
||
public void Parse() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This has a horrible name, as it generates code, not parse the
*.{msg,srv,action}
, but that is the authors of ROS#'s fault - This can be expanded with a custom interface / method such that code generated support serialization of custom types.
Also: we are required to add more licensing information as ROS# uses Apache 2.0 https://snyk.io/learn/apache-license/ |
…lement IDisposable to dispose reader, code cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vil bare forsikre meg med dere som kan litt mer at dette ikke er store problemer før vi merger
Er sikkert ennå noen bugs i endringene jeg har gjort, men ser ikke at det skal hindre merge fra nåværende tidspunkt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sånn jeg ser det påvirker ikke denne koden det andre for øyeblikket, som gjør at det ikke vil oppstå rare feil med resten av koden dersom det merges
Path forward
I would
ILogger
instead ofverbose
, probably print warnings with the ILogger (Should check how Support code-generation for messages at build time #57 source-generators expect warnings). Update: should use https://github.com/dotnet/roslyn/blob/main/docs/features/source-generators.cookbook.md#issue-diagnostics, documentation here: https://docs.microsoft.com/en-us/dotnet/api/microsoft.codeanalysis?view=roslyn-dotnet-4.0.1(msg-text) => C# source code
.