Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support command environment variables on Windows #1635

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

ferki
Copy link
Member

@ferki ferki commented Jan 20, 2025

This PR is a proposal to fix #1632 by prefixing commands on Windows with set calls to set environment variables.

Checklist

  • based on top of latest source code
  • changelog entry included
  • automated tests pass
  • git history is clean
  • git commit messages are well-written

@ferki ferki force-pushed the windows_command_env branch from 67fc64b to eb8cbc4 Compare January 20, 2025 23:22
@ferki ferki merged commit 2dfe610 into master Jan 21, 2025
48 checks passed
@ferki ferki deleted the windows_command_env branch January 21, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support environment variables for running commands on Windows
1 participant