Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply --sidecar to *_edited.ext files when using it with osxphotos import #1470

Closed
RhetTbull opened this issue Mar 27, 2024 · 0 comments
Closed
Labels
cli Pertains to the command line interface feature request New feature or request

Comments

@RhetTbull
Copy link
Owner

See this in metadata_reader which handles the Google takeout case but not the osxphotos default cause (_edited). Might need a custom --edited-suffix to match the one in osxphotos export

    stem = filepath.stem
    if stem.endswith("-edited"):
        # strip off -edited suffix
        stem = stem[:-7]
        new_filepath = filepath.with_stem(stem)
        return get_sidecar_for_file(new_filepath)
@RhetTbull RhetTbull added feature request New feature or request cli Pertains to the command line interface labels Mar 27, 2024
RhetTbull added a commit that referenced this issue Jun 8, 2024
* Working on import fixes

* Working on --check

* More work on import check

* Got import check working

* Initial refactor of --check-not

* Working on import code

* Tests passing for import

* Fixed reporting for import

* Fixes #1470, apply sidecar to _edited photos, adds --edited-suffix

* Implements #1373, --favorite-rating

* Updated docs

* Implemented --auto-live, #1399

* Normalizes unicode for album names, #1475

* Added height, width to PhotoInfoFromFile

* Updated test names

* Adds --signature to import, #1374

* Fix test for linux

* Implements PR #1486

* Allow import to accept files or directories as argument

* Fixed error with files_or_dirs

* Added export_directory table

* ExportDB updates to allow reading last export path

* Added --runs to exportdb, updated exportdb tests

* Added photoinfo_from_dict

* Added photoinfo_from_dict tests

* Added --exportdb to import

* Stage files that need modification, added tests

* Refactoring for maintainability

* Refactoring for maintainability

* Refactoring for maintainability

* Changed verbose level

* Fix for files with same stemp when --auto-live is not used

* Handled edited version w/o AAE

* removed print statemetns

* Updated check, check not

* Added tests for importing edited versions

* Refactored to move import_cli code first in file

* Working on _edited photos

* Import of edited files now working

* Updated content_tree to fallback to mdls if needed

* Fixed image_file_utils for non-Spotlight volumes

* Fixed image_file_utils for non-Spotlight volumes

* Removed unneeded imports

* Tests passing for renamed edited photos

* Initial tests for import CLI utils

* Initial tests for import CLI utils

* Fixed regex for finding original / edited images

* Typo (my bad!) on GoPro Pics filename standards. (#1551)

* Added test images for import tests

* Fix for edited live photos

* Fixed skip if not macOS

* Added test for edited live photo

* Added clarification for --resume, --skip-dups, #802

* Fix for certain edited live photos

* Reset counter

* Added --exportdir

* Fixed help formatting

---------

Co-authored-by: oPromessa <mario@silvapereira.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Pertains to the command line interface feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant