fix(class/cache): Fix magic call may cause exception

Rhilip · Jul 20, 2019 · 5d1434c · 5d1434c
1 parent 9913873
commit 5d1434c
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/framework/Utils/ClassValueCacheUtils.php b/framework/Utils/ClassValueCacheUtils.php
@@ -18,13 +18,13 @@ protected function getCacheNameSpace(): string
 
     protected function getCacheValue($key, $closure)
     {
-        if (is_null($this->{$key})) {
-            $this->{$key} = app()->redis->hGet($this->getCacheNameSpace(), $key);
-            if (false === $this->{$key}) {
-                $this->{$key} = $closure();
-                app()->redis->hSet($this->getCacheNameSpace(), $key, $this->{$key});
+        if (is_null($this->$key)) {
+            $this->$key = app()->redis->hGet($this->getCacheNameSpace(), $key);
+            if (false === $this->$key) {
+                $this->$key = $closure();
+                app()->redis->hSet($this->getCacheNameSpace(), $key, $this->$key);
             }
         }
-        return $this->{$key};
+        return $this->$key;
     }
 }