perf(tracker): No need to explicit serialize announce data

Rhilip · Jul 25, 2019 · 68e4550 · 68e4550
1 parent b4543b1
commit 68e4550
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/apps/controllers/TrackerController.php b/apps/controllers/TrackerController.php
@@ -787,12 +787,12 @@ private function sendToTaskWorker($queries, $role, $userInfo, $torrentInfo)
          * Don't use json_{encode,decode} for the value of info_hash and peer_id will make
          * those function return FALSE
          */
-        return app()->redis->lPush('Tracker:to_deal_queue', serialize([
+        return app()->redis->lPush('Tracker:to_deal_queue', [
             'timestamp' => time(),
             'queries' => $queries,
             'role' => $role,
             'userInfo' => $userInfo,
             'torrentInfo' => $torrentInfo
-        ]));
+        ]);
     }
 }
diff --git a/apps/timer/TrackerAnnounceTimer.php b/apps/timer/TrackerAnnounceTimer.php
@@ -15,14 +15,13 @@ class TrackerAnnounceTimer extends Timer
     public function init()
     {
         while (true) {
-            $data_raw = app()->redis->brpoplpush('Tracker:to_deal_queue', 'Tracker:backup_queue', 5);
-            if ($data_raw !== false) {
-                $data = unserialize($data_raw);
+            $data = app()->redis->brpoplpush('Tracker:to_deal_queue', 'Tracker:backup_queue', 5);
+            if ($data !== false) {
                 app()->pdo->beginTransaction();
                 try {
                     $this->processAnnounceRequest($data['queries'], $data['role'], $data['userInfo'], $data['torrentInfo']);
                     app()->pdo->commit();
-                    app()->redis->lRem('Tracker:backup_queue', $data_raw, 0);
+                    app()->redis->lRem('Tracker:backup_queue', $data, 0);
                 } catch (\Exception $e) {
                     println($e->getMessage());
                     app()->pdo->rollback();
@@ -34,7 +33,6 @@ public function init()
         }
     }
 
-
     /** TODO 2018.12.12 Check Muti-Tracker behaviour when a Transaction begin
      * @param $queries
      * @param $seeder