Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRF Heat Map v2.1.0 #161

Merged
merged 28 commits into from
Nov 22, 2019
Merged

CRF Heat Map v2.1.0 #161

merged 28 commits into from
Nov 22, 2019

Conversation

samussiah
Copy link
Contributor

No description provided.

@samussiah samussiah added this to the v2.1.0 milestone Sep 11, 2019
@danedexF5
Copy link

danedexF5 commented Nov 21, 2019

Regression Tests

Filters and Options

  • * Confirm that the default values for the Summarize by filter are Site, Subject ID, and None
  • * Confirm that the Summarize by filters display the data in the correct nesting format. For instance, if the first drop-down is set to Site and the second drop-down is set to Subject ID, then the ID column should initially display Site IDs and when you click on a row it will expand to show the Subject ID rows
  • * Confirm that the Site drop-down filter to the left of the heat map contains all of the sites included with the dataset
  • * Confirm that the default value for the Site drop-down is All
  • * Confirm that selecting a site filters the chart to show only the data associated with that site
  • * Confirm that these filters should be present by default: Subset 1, Subset 2, Subset 3, Subject Freeze Status, and Subject Status. If any are missing, a warning should be in the log that reads The [ filter variable ] filter has been removed because the variable has only one level
  • * Confirm that the default value for the Subject Freeze Status filter is All (If filter not present, confirm that a message error is in the log)
  • * Confirm that selecting Not Ready to Freeze shows only subjects associated with that status (If filter not present, confirm that a message error is in the log)
  • * Confirm that the Subject Status filter has the following options: Completed, Enrolled, Screen Failure
  • * Confirm that choosing a Subject Status filter will only show subjects that are associated with that status
  • * Confirm that the default is for all of the Subject Status filter options to be selected
  • * Confirm that the 3 Subset filters to the left of the heat map have an option for All
  • * Confirm that the 3 Subset filters default to All
  • * Confirm that each Subset filter changes the display appropriately so that only the selected subset data is displayed
  • * Confirm that selecting the Expand All checkbox expands the ID column to show all of nested data
  • * Confirm that de-selecting the Expand All checkbox collapses all of the nested data and only the high level ID's are displayed
  • * Confirm that "Loading" text appears in the top left of the page when changing nesting or filters
  • * Confirm that the Subject Status filter is multi-selectable
  • * Confirm the three nesting controls appear above the chart
  • * Confirm the 3 Subset controls all have the same width
  • * Confirm the Webcharts controls appear to the left of the chart
  • * Confirm that a 'Ready for Freeze' column appears
  • * Confirm that a filter appears for 'Subject Freeze Status' and appropriately filters the data (If filter not present, confirm that a message error is in the log)
  • * Verify that the default nesting column names (the Summarize by selection options) appear as: Site, Subject ID, Folder, Form
  • * Verify you can change the default labels of nesting columns to custom labels
  • Set the Summarize by to Folder at the top level and verify that the folders are sorted numerically instead of alphabetically
  • * Confirm that when the Summarize by subset filters nest to 'subject ID' 'folder' 'form', that it doesn't take more than a few seconds.
  • Set the Summarize by nests to Subject ID, Folder, Form. Check 'Expand All' box and verify that a message appears warning the user that this action will draw a lot of rows and prompting them to confirm.
  • * Confirm the nesting options auto change (Example: Set the nests to Subj ID, Folder, Form. Then bump them up so Folder is on top, Form is second and then the third nest should auto set to None.)
  • * Confirm the "All" filter logic is working as expected (Download the CAT data, add an "All" value in the "Status" column and upload the updated file. Select the top "All" option from the Subject Status dropdown and verify that all chart data is displayed. Select the second "All" option and verify that only a subset is displayed.)
  • * Confirm all filters are centered in the left-side panel so they can span the whole panel and their labels appear above them instead of beside them.
  • * Confirm nest variables (site, subject, folder, form) appear in the controls section as drop-downs above the other controls and subset the data upon selection.

Legends

  • * Confirm the CRF legend appears at the top of the page. It has %'s that range from light blue to dark blue, with the darker the blue indicating the higher % of complete
  • * Confirm the Queries legend appears at the top of the page. It has the number of queries completed that range from light green to dark green with the darker green indicating the higher number of complete

Chart: Column Sliders and Appearance

  • * Confirm that an "Overall" bar appears at the top of the chart showing study averages as a top row for each column.
  • * Confirm that each column has input boxes that appear at the top of each column
  • * Confirm that Form columns have a range of 0% to 100% and Query columns have a range of 0 to the max number of queries within that dataset
  • * Confirm that when you click in an input box and start typing, the chart does not update as you move it, but it updates after you click out of the box.
  • * Confirm up and down arrows appear beside numbers in input boxes and that they can increase or decrease the value.
  • * Confirm that multiple column input boxes can be adjusted simultaneously
  • * Confirm that the Reset Ranges button removes the filters and returns each column filter to the default
  • * Change the "sliders" setting to True
  • * Confirm that when you click on a slider and drag it around on its range, the chart does not update as you move it, but it updates after you release the slider.
  • * Confirm that multiple column sliders can be adjusted simultaneously
  • * Confirm that the Reset Sliders button removes the filters and returns each column filter to the default
  • * Confirm that gridlines appear between cells
  • * Verify that N/A cells are labeled as such
  • * Verify that N/A cells are the same color as 100% columns (Dark blue)
  • * Confirm that when set a slider to a value that the parent does not match, but at least one child does, the parent remains visible and its children display below it when the nest is expanded. Verify that the parent row is shaded gray and that its percentage is still visible and shows in black text.
  • Drag a top slider below 100% and verify that it filters out N/A cells.
  • Set the column filter boxes to two numbers that are the same as values in that column and verify that both rows do not disappear. (e.g. using the default data set the filter for Entered to 39% - 76% and verify that the rows with 76% and 39% both stay
  • Download the CAT data (use the csv export on the Preview page, not the export on the main page), add a lengthy value in the sitename column like "wow, this is really lengthy-I'm kind of shocked at how lengthy this has gotten", and upload the updated file. Verify that this ID value in the heatmap does not wrap, gets cut off, and that you can see the full text by hovering over it
  • * Confirm that setting the top level nesting variable to "Form" sets the form at the top to "DM"
  • * Confirm that removing the form_ordinal setting and verify that forms display alphabetically instead
  • * Verify that info bubbles no longer appear next to column headers and that hovering over these headers causes a question mark cursor and the details about the column to appear
  • Change the second nesting dropdown to "None" and verify that the third dropdown is disabled and you are unable to change it
  • * Confirm that setting all values of a filter variable equal to the same value and rendering the chart will cause the filter to not show up, and a note should print to the console that it was removed (Download the data file. Delete all values in any of these columns: status, subjfreezeflg, sitename, subset1, subset2, subset3. Upload the edited data file and re-render the chart. The filter representing the edited column should not appear.)
  • * Confirm that removing the following settings doesn't effect the charts ability to render appropriately (visit_order_col, status filter_col (you'll remove the whole object so delete : { value_col: 'status' label: 'Subject Status', subject_export: true } subjfreezeflg filter_col (remove whole object just like above) )
  • * Verify that fractions appear next to all percentages when the 'Display Fractions' control is checked and disappear when it is unchecked
  • * Click an id and verify that it's children rows that appear also have fractions
  • * Check a fraction and verify that it equals the percentage it's paired with (it'll round down to the percentage)

Exports

  • * Confirm that data export buttons appear at the bottom of the page, CSV, XLSX and Report.
  • * Confirm that each option is able to produce an export of the current data opened in excel
  • * Confirm that if using the XLSX export option, a second tab appears which lists the filter options that were selected to produce the current data export
  • * Confirm that if a subject is a nest variable that subject-level characteristics like 'Subject Status' appear in the output of an export
  • * Confirm that if a subject is not a nest variable then subject-level characteristics like 'Subject Status' do not appear in the output of an export
  • * Confirm that when clicking on one of the export buttons, the output does not contain total rows for the nesting columns
  • * Verify that a csv export contains information on the currently applied filters
  • * Verify that an xlsx export contains information on the currently applied filters in the second tab but does not in the first tab
  • * Verify that subject status, freeze status, and site appear in the export when subject is a nest level
  • * Download the xslx export and verify that its colors and values in excel match those on the renderer
  • * Verify that a 'Report' button appears beside the regular export buttons
  • * Confirm that you can download the report by clicking the button
  • * Verify that the downloaded xlsx contains four tabs - one for each nesting variable (and a tab for filters)
  • * Set the renderer to have the nesting : Forms. Then verify that the values, colors, and order of rows in the Forms tab of the automated report match the newly rendered renderer
  • * Download csv output and verify that the values under the Filter column match the names of the filters in the renderer (e.g. Site, Folder, Subset 1) not be the raw column names (e.g. sitename, foldername, subset1). Repeat for the 'Current Filters' tab in xlsx output.
  • * Verify that when you open the Report export, 'folderinstancename' does not appear but instead the column header is 'Folder'.
  • * Verify that when you open the xlsx export, 'sitename' does not appear but instead the column header is 'Site'.
  • * Verify that when you open the xlsx export, 'subjectnameoridentifier' does not appear but instead the column header is 'Subject ID'.
  • * Verify that when you open the Report export, 'ecrfpagename' does not appear but instead the column header is 'Form'
  • * Confirm that when clicking on the report button, the export xlxs subject-level columns (site, subject status & subject freeze status) are not blank where their headers appear
  • * The columns (site, subject status & subject freeze status) should only appear if there's a subject column (e.g. the first tab of the report shouldn't have them, but the other three should)
  • * When clicking the "Report" button, verify that the Folder tab of the report has site and subject nest columns
  • * When clicking the "Report" button, verify that the Form tab of the report has site, subject, and folder nest columns.
  • * Change some of the filter values on the renderer. Click the "Report" button and verify that a filters tab appears in the report that matches the currently selected filters

Miscellaneous

  • * Confirm crfHeatMap.js appears in the top-level of the repo rather than in the build folder.
  • * Confirm the following destroy method works (It'll be easier to follow the directions here: Add a destroy method. #135 as there are also visuals in case there is something confusing about the muli-part test)

Regression tests filter options may vary by dataset. This test is based on the dataset dataCleaning/rx_DataPage.csv

@rchronowic rchronowic self-requested a review November 22, 2019 19:08
Copy link

@rchronowic rchronowic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Regression testing.

@pburnsdata pburnsdata merged commit f749e81 into master Nov 22, 2019
@pburnsdata pburnsdata deleted the dev-v2.1.0 branch November 22, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants