-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug where hidden variables show up in groups/filters when checkin… #139
Conversation
…g group/filter boxes on the settings tab of hidden variables
Assign class of hidden to group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiding a variable that is currently used as a filter results in unexpected behavior. e.g. Data is still subset after filtering on a single site, and then hiding the site variable. Created issue #141 to resolve.
Fixed @jwildfire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samussiah Re-initializing seems to work, but now, the filter and group checkboxes don't seem to be doing anything :(
@@ -0,0 +1,21 @@ | |||
export default function reset(codebook) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. created #144 for a future release.
…g group/filter boxes on the settings tab of hidden variables
Closes #138