Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where hidden variables show up in groups/filters when checkin… #139

Merged
merged 3 commits into from
Jul 6, 2017

Conversation

samussiah
Copy link
Contributor

…g group/filter boxes on the settings tab of hidden variables

Closes #138

…g group/filter boxes on the settings tab of hidden variables
@samussiah samussiah requested a review from jwildfire July 3, 2017 19:43
@samussiah
Copy link
Contributor Author

samussiah commented Jul 3, 2017

Assign class of hidden to group options and filter lis on update().

@samussiah samussiah added this to the v1.1.0 milestone Jul 3, 2017
Copy link
Contributor

@jwildfire jwildfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding a variable that is currently used as a filter results in unexpected behavior. e.g. Data is still subset after filtering on a single site, and then hiding the site variable. Created issue #141 to resolve.

@samussiah
Copy link
Contributor Author

Fixed @jwildfire

@samussiah samussiah self-assigned this Jul 6, 2017
Copy link
Contributor

@jwildfire jwildfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samussiah Re-initializing seems to work, but now, the filter and group checkboxes don't seem to be doing anything :(

@@ -0,0 +1,21 @@
export default function reset(codebook) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. created #144 for a future release.

@jwildfire jwildfire merged commit ad3a4bf into v1.1-dev Jul 6, 2017
@jwildfire jwildfire deleted the hidden-settings-fix branch July 19, 2017 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants