V1.5.0 dev #300
V1.5.0 dev #300
Conversation
Update LICENSE.md
src/explorer/initFileLoad.js
Outdated
|
|
||
| var files = explorer.dataFileLoad.loader.node().files; | ||
| //clear the file input | ||
| loadStatus.text('Loaded.').style('color', 'green'); |
There was a problem hiding this comment.
should update this to say Loaded . instead of replacing the Choose a File text. Captured in #303 .
src/explorer/makeCodebook.js
Outdated
| @@ -41,7 +41,9 @@ export function makeCodebook(explorer) { | |||
|
|
|||
| explorer.codebook.on('complete', function() { | |||
| explorer.fileListing.init(explorer); | |||
| initFileLoad.call(explorer); | |||
| if (explorer.config.fileLoader) { | |||
There was a problem hiding this comment.
that's pretty darn to-the-point
src/explorer/fileListing/onDraw.js
Outdated
| f[explorer.config.labelColumn] === | ||
| explorer.current[explorer.config.labelColumn] | ||
| ) | ||
| .filter(f => f.fileID === explorer.current.fileID) |
There was a problem hiding this comment.
could also do .classed('selected', f => f.fileID === explorer.current.fileID) because i like to nitpick
There was a problem hiding this comment.
yeah, that would be cleaner. I'll commit the update.
src/explorer/setDefaults.js
Outdated
| f.settings = f.settings || {}; | ||
| f.fileID = i; |
| makeCodebook() {} | ||
| }; | ||
|
|
||
| explorer.on = function(event, callback) { |
| @@ -1,6 +1,7 @@ | |||
| const defaultSettings = { | |||
| ignoredColumns: [], | |||
| meta: [], | |||
| defaultCodebookSettings: {}, | |||
There was a problem hiding this comment.
effectively a single codebook settings object that applies to all codebooks? rather than individual settings?
|
@emmorris @danedexF5 I think we can probably skip (or do a very minimal) regression testing for this release since it only applies to the |
jwildfire
requested review from
danedexF5
and removed request for
danedexF5 and
emmorris
This release focuses exclusively on updates to the
explorerobject. Biggest feature update is a new file loader accessed withexplorer.config.fileLoader = true. Lots of other smallish technical updates including callbacks and easier ways to customize all codebooks created within an explorer.