fix TypeScript declarations

[eventualbuddha]

There's no default export, so don't use default exports in the type declarations. Also fixes a few other issues.

[Rich-Harris]

Thanks — not sure I understand what you mean by there being no default export? pkg.main has a module.exports =, but pkg.module has both a default and a named export (index.js corresponds to pkg.module, index-legacy.js to pkg.main).

[eventualbuddha]

See https://github.com/eventualbuddha/magic-string-typescript-test.

[eventualbuddha]

An alternative way to fix this is to add a default property to MagicString which also refers to MagicString.

[Rich-Harris]

Gah. Looks like the problem here is that ts-node is importing pkg.main rather than pkg.module. Does that sound right? If so, adding MagicString.default = MagicString here probably is the best fix, yes.

[eventualbuddha]

It's not specific to ts-node. This is what TypeScript generates:

"use strict";
exports.__esModule = true;
var magic_string_1 = require("magic-string");
new magic_string_1["default"]('abc');

So yeah, maybe do this?

Object.defineProperty(MagicString, 'default', { value: MagicString });

[Rich-Harris]

Will do — though I consider the lack of interoperability a bug in TypeScript!

[eventualbuddha]

Will do — though I consider the lack of interoperability a bug in TypeScript!

Here's a long discussion about it: microsoft/TypeScript#2719.

[Rich-Harris]

Lordy. Imagine if the JS gods had given us modules that didn't have privileged default exports, or if Node hadn't decided to tear up CommonJS 1.1 in the first place. We could probably have transitioned the whole ecosystem by now...

[Rich-Harris]

Have released 0.21.2 with that change, so I'll close this. Thanks!