feat(x_google_ignoreList): initial support for ignore lists #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces support for the `x_google_ignoreList` field to the `SourceMap` class. This extension was added to the Source Map Revision 3 Proposal[^1] to allow build tools to provide hints to debuggers (e.g. browser DevTools) about which files contain library or framework, and should thus be ignored by default for the purpose of stepping, break on exceptions, and the like[^2]. With this change it's possible for consumers of magic-string's `SourceMap` class to thread through and serialize the newly added `x_google_ignoreList` field (for example this is needed for rollup to support `x_google_ignoreList`). In a follow up change, we will also add support to the `Bundle` class to mark certain sources as ignore listed. [^1]: https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k [^2]: https://developer.chrome.com/blog/devtools-better-angular-debugging/
|
For more context: This is part of the changes we are planning to make to improve the interoperability between Vite and Chrome DevTools. |
|
@antfu could you include this in the next release please? |
|
released as 0.29. thanks! |
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces support for the
x_google_ignoreListfield to theSourceMapclass. This extension was added to the Source Map Revision 3 Proposal1 to allow build tools to provide hints to debuggers (e.g. browser DevTools) about which files contain library or framework, and should thus be ignored by default for the purpose of stepping, break on exceptions, and the like2.With this change it's possible for consumers of magic-string's
SourceMapclass to thread through and serialize the newly addedx_google_ignoreListfield (for example this is needed for rollup to supportx_google_ignoreList).In a follow up change, we will also add support to the
Bundleclass to mark certain sources as ignore listed.Ref: #241
Footnotes
https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k ↩
https://developer.chrome.com/blog/devtools-better-angular-debugging/ ↩