fixed broke metrics endpoint per argoproj#1634

RichardAvendano · Oct 19, 2019 · f992577 · f992577
1 parent dd517e4
commit f992577
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/workflow/metrics/collector.go b/workflow/metrics/collector.go
@@ -96,7 +96,7 @@ func (wc *workflowCollector) Collect(ch chan<- prometheus.Metric) {
 
 func (wc *workflowCollector) collectWorkflow(ch chan<- prometheus.Metric, wf wfv1.Workflow) {
  addConstMetric := func(desc *prometheus.Desc, t prometheus.ValueType, v float64, lv ...string) {
- lv = append([]string{wf.Namespace, wf.Name}, lv...)
+ lv = append([]string{wf.Namespace, wf.Name, wf.Spec.Entrypoint}, lv...)
  ch <- prometheus.MustNewConstMetric(desc, t, v, lv...)
  }
  addGauge := func(desc *prometheus.Desc, v float64, lv ...string) {
@@ -110,7 +110,7 @@ func (wc *workflowCollector) collectWorkflow(ch chan<- prometheus.Metric, wf wfv
  return strings.Join(templates, ",")
  }
 
- addGauge(descWorkflowInfo, 1, wf.Spec.Entrypoint, wf.Spec.ServiceAccountName, joinTemplates(wf.Spec.Templates))
+ addGauge(descWorkflowInfo, 1, wf.Spec.ServiceAccountName, joinTemplates(wf.Spec.Templates))
 
  addGauge(descWorkflowStatusPhase, boolFloat64(wf.Status.Phase == wfv1.NodePending || wf.Status.Phase == ""), string(wfv1.NodePending))
  addGauge(descWorkflowStatusPhase, boolFloat64(wf.Status.Phase == wfv1.NodeRunning), string(wfv1.NodeRunning))