install -D is not portable

[carlocab]

d799fe1 changed the mkdir and install calls to install -D, but this flag is not portable. In particular, this leads to build failure on macOS (and, presumably, anywhere else that uses BSD install).

See Homebrew/homebrew-core#87971.

[alerque]

Oh bother and confound it all, half the point of some of my overhauls has been to improve portability, so sorry about this regression. Sometimes GNU syntax is just so temptingly BETTER! I'll try to get some CI running (perhaps on Cirrus BSD runners) so we're actually testing BSD installs on every commit.

[RichiH]

I didn't see d799fe1 come through at the time (sorry...). Most if not all of my weirdly elaborate and long-form commands are that way because that was the only POSIX/UNIX way to make them work.

See #322 for fix & new release.

[RichiH]

@carlocab thanks for the report. Can you confirm if 2.0.4 builds for you, please?

[carlocab]

Since you're already using GitHub actions, you can also run your build on macOS CI. It should be as simple as adding macos-latest here:

vcsh/.github/workflows/build.yml

Line 8 in 9a2bce5

runs-on: ubuntu-latest

You'll probably need something like

matrix:
    os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}

but I'm no expert on GitHub actions.

Can you confirm if 2.0.4 builds for you, please?

Thanks! I'll give it a try.

[carlocab]

The new release works great. Thank you.

[RichiH]

@carlocab thanks for reporting & checking!

Do you want to submit a PR for the build system?

[carlocab]

I've still got a lot of work at Homebrew (new macOS version just dropped), but ping me in about two weeks and I'll try and help you out with that :)

[RichiH]

I will leave it open then and try to set a reminder for myself to poke you. :)