-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clap integration #39
Clap integration #39
Conversation
}) | ||
} | ||
|
||
fn get_doc_comments(attrs: &[syn::Attribute]) -> Vec<String> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we lose this functionality, or is it handled elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clap should convert documentation on fields to argument hints/help strings etc automatically, when parsing if the help arg is detected a special error is thrown Which then gets displayed as the appropriate help message (or version string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a basic docs and code quality review: I'll defer to folks with more experience here on the overall architecture. Seems to slot in pretty perfectly though.
Much appreciated Alice! |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice changes.
This PR:
clap
as the command parserclap
#37 and Possible licensing issue #38