Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clap integration #39

Merged
merged 18 commits into from
Jan 9, 2023
Merged

Clap integration #39

merged 18 commits into from
Jan 9, 2023

Conversation

makspll
Copy link
Collaborator

@makspll makspll commented Jan 8, 2023

This PR:

@makspll makspll mentioned this pull request Jan 8, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
})
}

fn get_doc_comments(attrs: &[syn::Attribute]) -> Vec<String> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we lose this functionality, or is it handled elsewhere?

Copy link
Collaborator Author

@makspll makspll Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clap should convert documentation on fields to argument hints/help strings etc automatically, when parsing if the help arg is detected a special error is thrown Which then gets displayed as the appropriate help message (or version string)

Copy link
Contributor

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a basic docs and code quality review: I'll defer to folks with more experience here on the overall architecture. Seems to slot in pretty perfectly though.

@makspll
Copy link
Collaborator Author

makspll commented Jan 8, 2023

Just a basic docs and code quality review: I'll defer to folks with more experience here on the overall architecture. Seems to slot in pretty perfectly though.

Much appreciated Alice!

makspll and others added 6 commits January 8, 2023 22:05
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Copy link
Collaborator

@brandon-reinhart brandon-reinhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice changes.

@makspll makspll merged commit c1d4f7c into main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants