Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

indygreg
Copy link
Contributor

I ran into "dependency hell" related to rpm-rs using old crate versions when trying to upgrade dependencies in https://github.com/indygreg/PyOxidizer/. It's unfortunate that this happens in the first place. But it is what it is.

I pieced together a few commits to upgrade most of the crates in this project to their latest versions. cargo upgrades (from cargo-upgrades crate) tells me only the rsa and rsa-der crates are lagging behind after this change. Unfortunately, it appears we can't touch either due to the latest version of the pgp crate depending on the current versions. So this PR takes us as far as we can currently go.

While I'm here, could you please set expectations on ETA for a new release? I'd like to decide if I should wait for a new version of this crate or temporarily disable some projects due to crate incompatibilities. (I wish I didn't have to burden you with this request. But that's the world that crates.io crates for us for better or for worse.)

This is actually a single major version release from 0.6. The new
version standardizes on the Digest trait used in other digest crates.
That means its API is now consistent with other crates used by this
package.

One notable difference is the new Digest trait doesn't have an easy way
to format the digest to hex. So we just feed the binary data into
hex::encode().
This seems pretty straightforward.
Let's stay modern.

This upgrade is pretty impactful for me because all crates in a
dependency graph using zstd must agree on the same version because of
the library dependency. And the Rust crates ecosystem largely adopts
newer versions as they are released.
@dralley
Copy link
Contributor

dralley commented Jun 23, 2022

@Richterrettich Can we get this merged with a new patch release?

pgp 0.8.0 was released a few days ago and upgrades a bunch of
cryptograph dependencies. We need to upgrade rsa with pgp to
keep dependency resolution happy.
phlay pushed a commit to phlay/rpm-rs that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants