Add helm chart #248
Add helm chart #248
Conversation
|
Confirmed chart deploys successfully values:
custom_mappings: |
remote-urls:
- https://raw.githubusercontent.com/RickDB/PlexAniSync-Custom-Mappings/main/series-tvdb.en.yaml
- https://raw.githubusercontent.com/RickDB/PlexAniSync-Custom-Mappings/main/movies-tmdb.en.yaml
image: ghcr.io/rickdb/plexanisync:1.4
settings:
plex_section: Anime|Anime Movies
plex_url: https://plex.tld.org
ani_username: <username>
plex_episode_count_priority: true
tokens:
ani: <ani-token>
plex: <plex-token> |
|
@reconman Thoughts on getting this merged? |
| @@ -0,0 +1,81 @@ | |||
| --- | |||
| apiVersion: apps/v1 | |||
| kind: Deployment | |||
There was a problem hiding this comment.
I'm not 100 % sure but I think this could also be solved with a CronJob instead of starting a pod that does nothing 99 % of the time.
The entrypoint.sh needs to be adjusted so the docker image can also be run without the sleep loop, like by quitting the script if INTERVAL is <= 0.
There was a problem hiding this comment.
Yep, you're definitely right, a cronjob is the better solution.
I wasn't sure if the changes needed to support the cronjob would be welcomed, so I was pretty conservative with the chart.
I've gone ahead and updated the entrypoint script.
The chart defaults to a cronjob, with a user configurable schedule, but you can disable the cronjob, in which case a deployment will be created, and the interval setting used instead.
I inspected the chart outputs with all of the various setting, as well as linting with lube-lint. I haven't had the opportunity to test the chart since I also need a new container image built.
Can you kick off the workflow for a container image? If you don't want to, I can get something built on my fork. Hopefully take care of that tomorrow
There was a problem hiding this comment.
The PR workflow doesn't actually push docker images so I adjusted the entrypoint myself in the master branch.
Use the latest master image to test your changes.
|
@reconman I ended up making some changes, and removed the option for a deployment, it was redundant, and I didn't like how it unnecessarily complicated the chart. I've deployed the chart to my cluster, and tested with the latest master. It worked as expected, and exited after it finished. values:
custom_mappings: |
remote-urls:
- https://raw.githubusercontent.com/hollanbm/PlexAniSync-Custom-Mappings/main/series-tvdb.en.yaml
- https://raw.githubusercontent.com/hollanbm/PlexAniSync-Custom-Mappings/main/movies-tmdb.en.yaml
image: ghcr.io/rickdb/plexanisync:master
settings:
plex_section: Anime|Anime Movies
plex_url: https://plex.tld.org
ani_username: <username>
plex_episode_count_priority: true
tokens:
ani: <ani-token>
plex: <plex-token> |
|
Regarding the github pages, I don't have the permission to change the settings to enable them. Only @RickDB can do it:
|
Does he still contribute or manage the repo at all? |
Updated 👍🏻 |
I recently found your app and wanted to get it set up on my cluster. I noticed there wasn't a helm chart, so I went ahead and created one. I made a README.md for the chart, which goes over each setting in the chart, the default values, and provides some examples
I also added a workflow to package/publish the chart using gh-pages automatically.
There is a little repo setup in order to configure gh-pages.
See chart-releaser-action#pre-requisites for more details