Improve property name escaping #1638
Merged
+146
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
improve-property-name-escape
branch
from
91ccd4b
to
75976bf
Compare
* don't allow "init", "fromJS" or "toJSON" for TypeScript member name * improve performance by not doing string.Replace unless necessary
lahma
force-pushed
the
improve-property-name-escape
branch
from
75976bf
to
fcc3e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit a small snag without library that has member called
Initin it...init,fromJSortoJSONfor TypeScript member namedecimal.ToString+decimal.Parsethat were failing in non-US locale (the source value is already a decimal)