Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve property name escaping #1638

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Oct 25, 2023

Hit a small snag without library that has member called Init in it...

  • don't allow init, fromJS or toJSON for TypeScript member name
  • improve performance by not doing string.Replace unless necessary
  • remove odd decimal.ToString + decimal.Parse that were failing in non-US locale (the source value is already a decimal)

@lahma lahma requested a review from RicoSuter October 25, 2023 10:57
@lahma lahma force-pushed the improve-property-name-escape branch from 91ccd4b to 75976bf Compare October 26, 2023 04:32
* don't allow "init", "fromJS" or "toJSON" for TypeScript member name
* improve performance by not doing string.Replace unless necessary
@lahma lahma force-pushed the improve-property-name-escape branch from 75976bf to fcc3e53 Compare October 26, 2023 04:47
@RicoSuter RicoSuter merged commit 28611ab into RicoSuter:master Oct 30, 2023
1 check passed
@lahma lahma deleted the improve-property-name-escape branch October 31, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants