Add support for non-string discriminators using System.Text.Json #1724
+42
−2
Annotations
11 warnings
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Converters/JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/EnumTests.cs(54,22): warning CA1711: Rename type name ContainerWithEnumDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/EnumTests.cs(72,21): warning CA1711: Rename type name MyEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
|
|
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/EnumTests.cs(106,21): warning CA1711: Rename type name EnumWithFlags so that it does not end in 'Flags' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
|
This job succeeded
Loading