-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IDocumentProvider
service and its implementation (2)
#1677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1626 - does not "provide an api to generate multiple / all documents"; could be layered on this work - otherwise, meets requirements listed in #1626 - assumes the following answers to open questions in #1626 (generally means everything is opt-in) - without an `AddSwagger()` call, `IDocumentProvider` service will not exist - registered document name / identifier is new `SwaggerSettings<>.DocumentName` property - document is not registered unless `DocumentName` is non-`null` i.e. `IDocumentProvider` won't know about it - `SwaggerSettings<>.MiddlewareBasePath` and `SwaggerRoute` are independent of `DocumentName` - middleware does not depend on the `IDocumentProvider` or registrar services; duplicating some code - many thanks to @rynowak for writing this proposal
…umentProvider` - remove some code from files added in 5b7e0a3b34 - revert changes made in 5b7e0a3b34 to existing files
- `internal` again - commit 4057107.
…s(...)` - add NSwag.Sample.OpenApi project - rework bd9c7fc; revert part of that commit e.g. undo `SwaggerExtensions` changes nit: - correct doc comment for `AspNetCoreToSwaggerGeneratorSettings` WIP: - some doc comments are currently empty - names are tentative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDocumentProvider
service and its implementation #1658Question:
Simple config:
Advanced config: