Aligned OpenAPI code generation for file more with OpenAPI specification #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. |
RicoSuter
added a commit
that referenced
this pull request
Aug 3, 2020
* Add support for using controllers' summary as tag description (#2949) * Add support for using controllers' summary as tag description * Ensure tag only added to document if there's description * Cleanup * Move code Co-authored-by: Rico Suter <mail@rsuter.com> * Fix contract, closes #2933 * Update README.md * Update README.md * Update README.md * Update README.md * Bump elliptic from 6.4.0 to 6.5.3 in /src/NSwag.Sample.NetCoreAngular (#2968) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.0 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.4.0...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix for File Parameter interface not generated in some instances (#2972) - Split the Binary tests into 3 so each endpoint can be generated properly without missing the FileParameter interface - changed RequiresFileParameterInterface logic so it checks isBinary on arrays and nested objects Co-authored-by: Craig Ngu <Craig.Ngu@globalx.com.au> * Correct link in markdown for MS Build Targets (#2958) * Aligned OpenAPI code generation for file more with open API specification (#2896) * Reworked C# client response handling (#2959) * Reworked C# client response handling * Disallowed null responses if the response type is not declared as nullable Fixed the remark in #2944 * Fixed nullability on File I/O * Fixed nullability on ConvertToString * Fixed PR remarks * Avoid nullability issues in Query parameters Addresses RicoSuter/NJsonSchema#1069 (comment) * Fixed invalid code if array value type is not string * v13.7.0 (#2978) * v13.7.0 * Fix test Co-authored-by: Leon V <leon99@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: craigngu <42369784+craigngu@users.noreply.github.com> Co-authored-by: Craig Ngu <Craig.Ngu@globalx.com.au> Co-authored-by: Jedidiah May <33727409+portlandtn@users.noreply.github.com> Co-authored-by: Nicolas Fløysvik <nico-floysvik@hotmail.com> Co-authored-by: Jérémy VIGNELLES <jeremyVignelles@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the multipart-form request for the request body schema to be an object instead of none, since this is more like the open api specification https://swagger.io/docs/specification/describing-request-body/file-upload/
This will also fix a problem with SwaggerUI where the browse button for file upload does not work, or does not appear.