Expose tags in operation model base #4213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicoSuter
reviewed
Sep 27, 2023
| @@ -289,6 +289,9 @@ public string Produces | |||
| /// <summary>Gets the operation extension data.</summary> | |||
| public IDictionary<string, object> ExtensionData => _operation.ExtensionData; | |||
|
|
|||
| /// <summary>Gets the operation tags </summary> | |||
| public string Tags => string.Join(",", _operation.Tags); | |||
There was a problem hiding this comment.
I think we should expose the string array, allows more custom scenarios in templates and you can still join within the liquid templates if needed.
There was a problem hiding this comment.
Lovely, that makes sense. I will make the change
There was a problem hiding this comment.
Addressed this PR comment in pr #4807
Kindly review that PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose operation tags in the OperationModelBase. These will come very handy on overriding template and to make it easy to work with from liquid I have exposed these as a comma delimited string.
Please kindly accept this PR if this change is reasonable and adheres to standards, thanks.