Only reference Microsoft.Extensions.PlatformAbstractions in .NET 6+ b… #4785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, not sure how that made the macOS tests fail :-( |
|
Is this PR still valid? Can you merge master in the branch? |
Numpsy
changed the title
|
I've rebased it onto the current master. The macos CI is still fialing, but then it looks like the Ubuntu build at https://github.com/RicoSuter/NSwag/actions/runs/8287816759 failed with the same error, so I'm not sure if that's related to the change, or if something is flakey elsewhere :-( |
|
maybe the wait time at https://github.com/RicoSuter/NSwag/blob/c0e16f9f6e4d692d3ab8dc6c7b2ce5e53498841c/src/NSwag.ConsoleCore.Tests/GenerateSampleSpecificationTests.cs#L57C25-L57C36 isn't long enough for the macos CI ? |
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uilds
A test based on the comments in #4716 (comment) - it looks to me like Microsoft.Extensions.PlatformAbstractions is only used in the .NET 6/7/8 builds and not the .NET 4.6.2 build, so lets try excluding the NuGet package refernece in the 4.6.2 build