Added unlimited allowance code along with test statements. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeghen
added a commit
that referenced
this pull request
Aug 16, 2021
* Added close stream by keeper (#11) * Added close stream by keeper * fixed stray typos * don't allow opening streams without > 8hours of stream balance * support non-18 decimal underlying tokens (USDC) * fix typo in name * add script for transfer ownership * shorten delay for more test loops * work in progress on close stream keeper * Added logging, testing for USDCx decimals * Added unlimited allowance code along with test statements (#22) * more WIP on the keeper * don't downgrade twice * misc. fixes for decimal tokens * remove sloppy comments Co-authored-by: Chinmay Sai Vemuri <55590938+rashtrakoff@users.noreply.github.com>
mikeghen
added a commit
that referenced
this pull request
Sep 10, 2021
* Added close stream by keeper (#11) * Added close stream by keeper * fixed stray typos * don't allow opening streams without > 8hours of stream balance * support non-18 decimal underlying tokens (USDC) * fix typo in name * add script for transfer ownership * shorten delay for more test loops * work in progress on close stream keeper * Added logging, testing for USDCx decimals * Added unlimited allowance code along with test statements (#22) * more WIP on the keeper * don't downgrade twice * misc. fixes for decimal tokens * remove sloppy comments * fix balance check decimal issue * keeper updates, misc. changes from deployment * fix event poll DAG, set starting block * added grafana to keeper * misc. keeper fixes for closing streams * add missing import * use datetime correctly * remove context from operator * remove context * fix string interpolation * try kwargs * use exchange addresses * call web3 functions * don't enumerate list * import dependancy for dag * bring back execution date * fix operator * fix typo * use right abi * update ricochet abi * remove gas mul. * add gas * support email notifications * check transaction status in conf. sensor * rex launchpad spec, misc. changes from deloyment * don't track rates in app * reluctantly adding emergency drain method * airflow improvements for tellor reporter * fixed typo * fix typo * change quote chars * return str * fix template field issue * added event emission and emergency close helper Co-authored-by: Chinmay Sai Vemuri <55590938+rashtrakoff@users.noreply.github.com>
IntegralTeam
pushed a commit
to IntegralTeam/ricochet
that referenced
this pull request
Jan 14, 2022
* Added close stream by keeper (Ricochet-Exchange#11) * Added close stream by keeper * fixed stray typos * don't allow opening streams without > 8hours of stream balance * support non-18 decimal underlying tokens (USDC) * fix typo in name * add script for transfer ownership * shorten delay for more test loops * work in progress on close stream keeper * Added logging, testing for USDCx decimals * Added unlimited allowance code along with test statements (Ricochet-Exchange#22) * more WIP on the keeper * don't downgrade twice * misc. fixes for decimal tokens * remove sloppy comments Co-authored-by: Chinmay Sai Vemuri <55590938+rashtrakoff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added or modifed code in
StreamExchange.sol,StreamExchangeHelper.solandSteamExchange.test.jsfor allowing unlimited allowance and testing for the same (issue #3).