Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2: Fix IDA and fee calculation issues #6

Merged
merged 12 commits into from
Jul 31, 2021
Merged

v1.2: Fix IDA and fee calculation issues #6

merged 12 commits into from
Jul 31, 2021

Conversation

mikeghen
Copy link
Contributor

@mikeghen mikeghen commented Jul 29, 2021 •
edited
Loading

  • Resolving the deadlock scenario where there are 0 shares in the IDA
  • Fixes an issue with how the fee was taken which resulted in a larger than expect fee
  • Includes v2 protocol spec MD file

@mikeghen mikeghen changed the title v1.2: Fix Zero IDA Shares Bug v1.2: Fix IDA and fee calculation issues Jul 31, 2021
@mikeghen mikeghen merged commit 7d35473 into main Jul 31, 2021
IntegralTeam pushed a commit to IntegralTeam/ricochet that referenced this pull request Jan 14, 2022
@mikeghen
v1.2: Fix IDA and fee calculation issues (Ricochet-Exchange#6)
90a5a8a 
* sushiswap oracle, tellor fallback, events

* update tests and readme

* eth->dai exchange testing

* check IDA shares before distribute

* misc. fixes for deploy

* Added notes for v2 spec

* calculate fee and distribute the actualAmount

* tests for fee and v1.2 deploy config

* script for setting rate tolerance

* support verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeghen