Feature/add rosetta model support #340
Conversation
Edjchg
requested review from
michaelgruner,
lleon95,
rrcarlosrodriguez and
jsalas98
There was a problem hiding this comment.
Please, check the indentation and code style guide:
https://developer.ridgerun.com/wiki/index.php?title=RidgeRun_Developer_Manual/Coding_Styles/C
| @@ -61,6 +61,18 @@ gboolean gst_subtract_mean(GstVideoFrame * inframe, GstVideoFrame * outframe, gd | |||
|
|
|||
| gboolean gst_pixel_to_float(GstVideoFrame * inframe, GstVideoFrame * outframe, gint model_channels); | |||
|
|
|||
| /** | |||
| * \brief Normalize the image to match the Rosetta input tensor requirements. | |||
There was a problem hiding this comment.
Please, do not introduce Rosetta into generic modules. Let's keep it as:
"Normalize grayscale image the image within a given mean and offset"
ext/r2inference/gstrosetta.c
Outdated
| #include "config.h" | ||
| #endif | ||
|
|
||
| #include "stdio.h" |
There was a problem hiding this comment.
Sort the includes appropriately. Check the includes order here: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
ext/r2inference/gstrosetta.c
Outdated
| 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z' | ||
| }; | ||
| char *final_phrase = | ||
| (char *) malloc (sizeof (char) * (MODEL_OUTPUT_ROWS) + 1); |
There was a problem hiding this comment.
Prefer glib functions for memory allocation too (i.e g_malloc0, g_free, etc)
ext/r2inference/gstrosetta.c
Outdated
|
|
||
| free (output); | ||
| return TRUE; | ||
|
|
| gst_apply_gray_normalization (GstVideoFrame * inframe, GstVideoFrame * outframe, | ||
| gdouble mean, gdouble offset) | ||
| { | ||
| gint i, j, pixel_stride, width, height; |
There was a problem hiding this comment.
Initialize these variables.
ext/r2inference/gstrosetta.c
Outdated
| // Checking if the actual max index value is different from '_' character | ||
| // and also, checking if i is greater than 0, and finally, checking | ||
| //if the actual max index is equal from the previous one. |
There was a problem hiding this comment.
Use a comment style only. GStreamer uses ANSI-C /* */
ext/r2inference/gstrosetta.c
Outdated
| "Rosetta", "Filter", | ||
| "Infers characters from an incoming image", | ||
| "Edgar Chaves <edgar.chaves@ridgerun.com>\n\t\t\t" | ||
| " Luis Leon <luis.leon@ridgerun.com>\n\t\t\t"); |
There was a problem hiding this comment.
Remove the last \n\t\t\t and the spaces at the beginning
Edjchg
force-pushed
the
feature/add-rosetta-model-support
branch
from
836af22 to
8125d08
Compare
Add the support for Rosetta model for character recognition.