-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert code to maven plugin #86
Comments
Riduidel
added a commit
that referenced
this issue
Mar 23, 2022
In fact, the way we load MavenProject objects is not the official maven way (which will have an impact on #86). As we load the MavenProject by simply reading the pom file (and not by using the Full Maven Powers), the parent may not be defined and, as a consequence, some infos are lacking. To fix that, I had to analyze if maven pom is loaded from a file, and when it is the case, I also have to check if parent path is good, which I do a bad way.
Starting this migration with @Bullfrog666 on command! |
Riduidel
pushed a commit
that referenced
this issue
May 22, 2022
Most complex part of #86 is implemented We now have a maven plugin able to run `ArchitectureDocumentationBuilder` (which fixes #153) and redirects all logs to maven logs (which fixes #154) This maven plugin uses a highly simplified version of [itemis cdi maven utils](https://github.com/shillner/maven-cdi-plugin-utils). In fact, we began by using their library, because it indeed made our life way simpler. Unfortunatly their library was unable to use the project classpath (which made the whole idea of allowing users to write their own `Arhcitecture` and `Enhancer`s useless). As a consequence, I had to rewrite the useflu parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the direct consequence of #81.
The module
architecture-documentation
which is in fact a perfect example of documentation, should not have any Java class declared in.Which means we have to create a maven plugin able to
ArchitectureDocumentationBuilder
class through Maven + Weld #153The text was updated successfully, but these errors were encountered: