Feature/convert to maven plugin #86 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next step will be to add groovy validation script ... But I let Jason take care of that 🤪
…es_as_config_properties' of github.com:Riduidel/agile-architecture-documentation-system into feature/convert_to_maven_plugin_#86_read_maven_properties_as_config_properties
1. Starting Weld in plugin 2. Using the weird model of itemis plugin model which split things again 3. Injecting maven model in plugin to have it visible from the weld side of the world It doesn't yet totally work, but I'm more confident than evenr
…idel/agile-architecture-documentation-system into feature/convert_to_maven_plugin_#86
1. Errors sent to maven output 2. Each IT test treated as a JUnit test (better for reporting)
…#86_ensure_project_version_is_logged' into feature/convert_to_maven_plugin_#86
…anism. This is better, stronger, and more elegant
…idel/agile-architecture-documentation-system into feature/convert_to_maven_plugin_#86
… sourceDir in ImplicitManager
To say things concisely 1. The itemis cdi-maven helper thingie couldn't add dynamically the current project classpath. As a consequence, the architecture class declared in architecture-documentation didn't load. 2. I had to change A BUNCH of things in that initial plugin code to adapt that framework 3. Deltaspike doesn't seems to support so well parallel enhancements, as defined in our code 4. There were some weird bugs regarding paths, and I clearly doesn't understand how it used to work All this has been fixed, sometimes easily, sometimes incredibly hardly It will be good to make code clearer AND more tested ...
Riduidel
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.