Merge pull request #430 from stleamist/bug/byadding-parts-extraattrib…

…utes-overriding Fixes an issue where `byAdding(.extraAttributes(_:))` removes previously assigned `extraAttributes`.
Rightpoint · Jun 12, 2023 · becf396 · becf396
2 parents f795ab3 + 90e216b
commit becf396
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Sources/StringStyle+Part.swift b/Sources/StringStyle+Part.swift
@@ -165,7 +165,7 @@ extension StringStyle {
     mutating func update(part stylePart: Part) {
         switch stylePart {
         case let .extraAttributes(attributes):
-            self.extraAttributes = attributes
+            self.add(extraAttributes: attributes)
         case let .font(font):
             self.font = font
         case let .link(link):

diff --git a/Tests/AttributedStringStyleTests.swift b/Tests/AttributedStringStyleTests.swift
@@ -829,6 +829,15 @@ class StringStyleTests: XCTestCase {
         BONAssert(attributes: childAttributes, key: .foregroundColor, value: BONColor.black)
     }
 
+    func testOverridingExtraAttributesPart() {
+        let style = StringStyle()
+            .byAdding(.extraAttributes([.backgroundColor: BONColor.white]))
+            .byAdding(.extraAttributes([.foregroundColor: BONColor.black]))
+
+        BONAssert(attributes: style.attributes, key: .backgroundColor, value: BONColor.white)
+        BONAssert(attributes: style.attributes, key: .foregroundColor, value: BONColor.black)
+    }
+
 }
 
 private extension StringStyleTests {