Nullability and Generics #107
Conversation
|
@jvisenti for your perusal. |
|
|
||
| @end | ||
| // clang-format off |
There was a problem hiding this comment.
#? Should this be clan-format on?
|
|
||
| /** | ||
| * Calls [self debugStringIncludeImageAddresses:YES] | ||
| * | ||
| * @return The debug string, including pointer addresses of attached images. | ||
| */ | ||
| - (NSString *)debugString; | ||
| - (NSString *_Nonnull)debugString; |
There was a problem hiding this comment.
#? doesn't - (nonnull NSString *)debugString work (here and elsewhere)?
There was a problem hiding this comment.
D'oh, so that's how you do it. I stopped at the first one I successfully got to compile. Fixing.
There was a problem hiding this comment.
_Nonnull and its ilk are for C functions (and therefore blocks as well).
|
@ZevEisenberg Looks good overall. You probably want to consider maintaining pre-Xcode 7 support via compatibility macros e.g. https://github.com/Raizlabs/RZImport/blob/master/Classes/RZCompatibility.h |
|
@jvisenti should be good to go now. I haven't tested in Swift. Would you mind checking it out in your Swift project and seeing if the edge cases with implicitly unwrapped optionals that you reported are handled correctly now? |
|
@ZevEisenberg Confirmed that this behaves as expected in a Swift app. |
…ity-and-generics Nullability and Generics
Closes #31