add support for line break mode #128
Conversation
|
|
||
| // Line Break Mode | ||
|
|
||
| if (self.lineBreakMode != NSLineBreakByWordWrapping) { |
There was a problem hiding this comment.
I would prefer not to rely on the implementation detail that this property is initialized to 0, which happens to equal NSLineBreakByWordWrapping. Please add explicit initialization to -init of BONText.m.
|
@tettoffensive thanks for your PR! If you'd be willing to address my one comment, then I'd happily test and merge this. |
|
@ZevEisenberg happy to address. I've added to the init |
| @@ -75,6 +75,7 @@ - (void)testParagraphStyle | |||
| .headIndent(2.34) | |||
| .tailIndent(3.45) | |||
| .lineHeightMultiple(3.14) | |||
| .lineBreakMode(NSLineBreakByTruncatingTail) | |||
There was a problem hiding this comment.
Would you mind moving this down below .lineSpacing(2.72)? Line break mode is after line spacing everywhere else, and that consistency makes it very easy to validate that it's in all the places it should be.
|
@tettoffensive just the one additional comment, and then I'm good to go. I double checked and tested it, and it looks great. |
|
@ZevEisenberg moved the line |
For #111