String transforms #275
Merged
String transforms #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZevEisenberg
force-pushed
the
feature/26-string-transforms
branch
from
9c0cfce
to
748d9d8
Compare
ZevEisenberg
commented
Mar 25, 2017
| @@ -173,7 +174,21 @@ extension StringStyle { | |||
| return attributedString | |||
There was a problem hiding this comment.
#? @KingOfBrian this is working, but how? If we return here, we won't ever get to the transform. I built this the other night, and everything seems to be working, but I can't see how.
There was a problem hiding this comment.
The XML Builder will call this again and again as it builds the XML string.
KingOfBrian
reviewed
Mar 26, 2017
Sources/XMLBuilder.swift
Outdated
| func foundNew(string theString: String) { | ||
| let newAttributedString = topStyle.attributedString(from: theString) | ||
| attributedString.append(newAttributedString) | ||
| } |
There was a problem hiding this comment.
Should be able to pull more logic in here, a bunch of duplication below.
KingOfBrian
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26.