Fixes #320. Fixes compiler errors and warnings encountered with Xcode 9.3 beta 2 #322
Conversation
…with Xcode 9.3. beta 2
rdingman
force-pushed
the
bugfix/xcode-9.3-beta-2-fixes
branch
from
453954b
to
6aab93d
Compare
|
@rdingman thanks for this PR! I've got one little tweak that I'd love to see: I prefer to avoid having Swift-version-specific conditionals in the main code wherever possible. Instead, I like to back-port new functions to the old version of Swift. We wrote up a blog post about this, but the short version is that, in the existing Compatibility.swift, we would expose a function called How does that sound? Please let me know if you'd like clarification, or if you don't have time to make the update, I can take it from here. |
|
Makes sense. I'll try to make those changes today. |
|
@rdingman perfect. Going to wait a little to merge until the Xcode is a little further along, because future betas may break more things, but I may publish this as a release candidate soon. |
|
This has been released as part of BonMot 5.1. Thanks for your contribution, @rdingman! 🚀 |
No description provided.