Xcode 11.4 fixes #389
Merged
Xcode 11.4 fixes #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZevEisenberg
force-pushed
the
bugfix/zeveisenberg/small-fixes
branch
from
39c644c
to
bdb517a
Compare
ZevEisenberg
commented
Apr 14, 2020
Current coverage for BonMot.framework is
|
| Files changed | - | - |
|---|---|---|
| StringStyle+Part.swift | 98.08% |
✅ |
Powered by xcov
Generated by 🚫 Danger
Comment on lines
+175
to
+178
| case let .underline(style, color): | ||
| self.underline = (style, color) | ||
| case let .strikethrough(style, color): | ||
| self.strikethrough = (style, color) |
There was a problem hiding this comment.
What was the warning here? Does this have something to do with a change in implicit tuple behavior?
Co-Authored-By: Chris Ballinger <cballinger@rightpoint.com>
Co-Authored-By: Chris Ballinger <cballinger@rightpoint.com>
|
For the sake of getting this merged more quickly, I'd say maybe revert the gem update, since it looks like fixing that will take a while. I'll take a deeper dive for that in a separate PR. |
This reverts commit 6593901.
|
I tried more conservatively updating just CocoaPods; we'll see if it's any happier now. |
chrisballinger
approved these changes
Apr 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.