Fix enum for module stability #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
| /// Property kept here for backward compatibility | ||
| @inlinable | ||
| public static var all: [Special] { allCases } |
There was a problem hiding this comment.
Can we mark this as deprecated?
There was a problem hiding this comment.
Good point, done
chrisballinger
approved these changes
Mar 15, 2021
nikolaytw
pushed a commit
to transferwise/BonMot
that referenced
this pull request
Mar 22, 2021
…e-stability Fix enum for module stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For working project, I need to build this pod as binary framework. To avoid rebuild it with every new xcode, we build them with
BUILD_LIBRARY_FOR_DISTRIBUTION=YES.In this mode, swift generate swiftinterface file, which is crucial for module stability
Unfortunately it has bug, which make swiftinterface invalid for BonMot specifically.
Here is link for swift bug: https://bugs.swift.org/browse/SR-14355
Looks like it just skip string literals, because they are not needed, and do not check that
RawValuetype is notString.I see no other way, rather than change raw type to String. In this way swiftinterface can be compiled.
Additionally I added
CaseIterableand still keepallfor backward compatibility.I would appreciate if you take my changes and create new release, so I would avoid creating fork of BonMot repo