Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For working project, I need to build this pod as binary framework. To avoid rebuild it with every new xcode, we build them with
BUILD_LIBRARY_FOR_DISTRIBUTION=YES
.In this mode, swift generate swiftinterface file, which is crucial for module stability
Unfortunately it has bug, which make swiftinterface invalid for BonMot specifically.
Here is link for swift bug: https://bugs.swift.org/browse/SR-14355
Looks like it just skip string literals, because they are not needed, and do not check that
RawValue
type is notString
.I see no other way, rather than change raw type to String. In this way swiftinterface can be compiled.
Additionally I added
CaseIterable
and still keepall
for backward compatibility.I would appreciate if you take my changes and create new release, so I would avoid creating fork of BonMot repo