-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: batch multiplex #1
base: development
Are you sure you want to change the base?
Commits on Dec 29, 2023
-
feat: add batch multiplex feature
- add batch multiple feature smart contract - add its interface - update 0x interface to inherit batch multiple methods - add sample batch multiplex validator contract
Configuration menu - View commit details
-
Copy full SHA for c686e47 - Browse repository at this point
Copy the full SHA c686e47View commit details -
move BatchMultiplexValidator contract to /examples folder
- create new /examples folder - move BatchMultiplesValidator.sol to /examples
Configuration menu - View commit details
-
Copy full SHA for 72caeec - Browse repository at this point
Copy the full SHA 72caeecView commit details -
use _getValidateSelector private method
- use private method instead of copy constant
Configuration menu - View commit details
-
Copy full SHA for 085b237 - Browse repository at this point
Copy the full SHA 085b237View commit details -
minor fixes in BatchMultiplexFeature
- added missing overrides - added missing parenthesis
Configuration menu - View commit details
-
Copy full SHA for d00b7a4 - Browse repository at this point
Copy the full SHA d00b7a4View commit details -
create new contracts artifacts
- update scripts to include new contracts - deploy new contracts in tests/utils/DeployZeroEx.sol - update artifacts.ts and wrappers.ts files
Configuration menu - View commit details
-
Copy full SHA for c86a07b - Browse repository at this point
Copy the full SHA c86a07bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a00232 - Browse repository at this point
Copy the full SHA 9a00232View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2012d50 - Browse repository at this point
Copy the full SHA 2012d50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd76c3 - Browse repository at this point
Copy the full SHA 5bd76c3View commit details
Commits on Dec 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 639d588 - Browse repository at this point
Copy the full SHA 639d588View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9ea1aa - Browse repository at this point
Copy the full SHA a9ea1aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1761ba - Browse repository at this point
Copy the full SHA b1761baView commit details -
remove input in BatchMultiplexFeature constructor in DeployZeroEx.sol
Configuration menu - View commit details
-
Copy full SHA for 1b007fd - Browse repository at this point
Copy the full SHA 1b007fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 059610d - Browse repository at this point
Copy the full SHA 059610dView commit details -
- pass encoded calls instead of calls array as validate(...args) first input
Configuration menu - View commit details
-
Copy full SHA for 8fc4a18 - Browse repository at this point
Copy the full SHA 8fc4a18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08199f5 - Browse repository at this point
Copy the full SHA 08199f5View commit details
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c885a4c - Browse repository at this point
Copy the full SHA c885a4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85418da - Browse repository at this point
Copy the full SHA 85418daView commit details
Commits on Jan 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c9dc5b9 - Browse repository at this point
Copy the full SHA c9dc5b9View commit details -
test: fix initial batchMultiplex tests
- assert meta transaction can be executed with batchMultiplex - assert onlySelf, onlyOwner modifiers not overruled by batchMultiples
Configuration menu - View commit details
-
Copy full SHA for 10d250f - Browse repository at this point
Copy the full SHA 10d250fView commit details
Commits on Jan 9, 2024
-
only revert if error handling is revert
- move revert transaction failed without error in if statement
Configuration menu - View commit details
-
Copy full SHA for ce0c4dd - Browse repository at this point
Copy the full SHA ce0c4ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3a998c - Browse repository at this point
Copy the full SHA e3a998cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 249eb15 - Browse repository at this point
Copy the full SHA 249eb15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29ddaba - Browse repository at this point
Copy the full SHA 29ddabaView commit details
Commits on Jan 13, 2024
-
- removed solved comments - added payable modifier to feature methods - added refundsAttachedEth, doesNotReduceEthBalance, onlyDelegateCall modifiers to methods - added new guard flag in reentrancy guard dep
Configuration menu - View commit details
-
Copy full SHA for b6d315c - Browse repository at this point
Copy the full SHA b6d315cView commit details -
Configuration menu - View commit details
-
Copy full SHA for adeb8df - Browse repository at this point
Copy the full SHA adeb8dfView commit details
Commits on Jan 16, 2024
-
refund up to sent eth excluding prev balance
- refund the minimum between eth attached and the eth left in the proxy net of eth stuck in the proxy before the transaction
Configuration menu - View commit details
-
Copy full SHA for 6f0e417 - Browse repository at this point
Copy the full SHA 6f0e417View commit details
Commits on Jan 19, 2024
-
- add test file - update setup pipeline
Configuration menu - View commit details
-
Copy full SHA for eaa13af - Browse repository at this point
Copy the full SHA eaa13afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f8f2af - Browse repository at this point
Copy the full SHA 2f8f2afView commit details -
- merge two batchMultiplex methods - name differently the 2 implemented methods to prevent console warning in tests and easier testing integration, using `batchMultiplex` and `batchMultiplexOptionalParams` - remove validate deploy and immutable, as moved in foundry test - use Contract.selector instead of hashing selector in migrate - use _revertWithData from ZeroEx.sol to allow decoding expected error - update interface - minor linting
Configuration menu - View commit details
-
Copy full SHA for 606fbaf - Browse repository at this point
Copy the full SHA 606fbafView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8e6feb - Browse repository at this point
Copy the full SHA b8e6febView commit details
Commits on Jan 20, 2024
-
test: add batch of swaps with multiple features
- swap zrx and dai with native fill RFQ order and multiplex sell token for token to uniswap through `batchMultiplex`method
Configuration menu - View commit details
-
Copy full SHA for e8959b9 - Browse repository at this point
Copy the full SHA e8959b9View commit details
Commits on Jan 21, 2024
-
- handle edge cases of ETH transfers - added internal methods for routing - prevent weth stuck if behavior is STOP - blacklist non-supported methods - store implementations of methods that require special handling - reserve 2 EP storage slots for batch multiplex stoage - update ci pipeline
Configuration menu - View commit details
-
Copy full SHA for f04ecca - Browse repository at this point
Copy the full SHA f04eccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48f645e - Browse repository at this point
Copy the full SHA 48f645eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31fffe0 - Browse repository at this point
Copy the full SHA 31fffe0View commit details -
- create private method _dispatch to handle execution in both external batch execute methods - remove unnecessary variable definitions - remove eventual weth balance in both methods
Configuration menu - View commit details
-
Copy full SHA for 14075e0 - Browse repository at this point
Copy the full SHA 14075e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02884e2 - Browse repository at this point
Copy the full SHA 02884e2View commit details -
retrieve target implementations from proxy storage
- removed mapping of selector to implementations from feature storage - store mapping of selectors that require routing - storage variable name shortening - retrieve address of target implementations from proxy storage - revert on more selectors
Configuration menu - View commit details
-
Copy full SHA for fa3da7c - Browse repository at this point
Copy the full SHA fa3da7cView commit details
Commits on Jan 22, 2024
-
simplify batch multiplex storage
- define only 1 mapping in storage, use enum instead of bool to define selector status - update storage initialization - move duplicate unwrap weth block to private method - added method for owner to update storage - added method to query a selector's status - rename immutable _weth to WETH
Configuration menu - View commit details
-
Copy full SHA for 028a51f - Browse repository at this point
Copy the full SHA 028a51fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a6afd1 - Browse repository at this point
Copy the full SHA 8a6afd1View commit details -
- reorder some methods according to flow: external, public, internal, private; write, read (view, pure)
Configuration menu - View commit details
-
Copy full SHA for 07844bf - Browse repository at this point
Copy the full SHA 07844bfView commit details
Commits on Jan 23, 2024
-
limit use of .call where required
- use delegatecall in transformERC20 if ETH is not the input token - use non-conditional `value` in .call as the non-ETH calls are re-routed with delegatecall - comment improvements
Configuration menu - View commit details
-
Copy full SHA for f189991 - Browse repository at this point
Copy the full SHA f189991View commit details -
custom-route
fillLimitOrder
method- create custom route as method will fail whenever eth is involved and another call using eth is executed - blacklist other limit orders - update comments
Configuration menu - View commit details
-
Copy full SHA for c4daa73 - Browse repository at this point
Copy the full SHA c4daa73View commit details -
- add limit order and wrap eth tests - refactor batch multiplex tests without using non-supported meta transactions
Configuration menu - View commit details
-
Copy full SHA for 3e1db28 - Browse repository at this point
Copy the full SHA 3e1db28View commit details
Commits on Jan 24, 2024
-
feat: add BatchMultiplexV2Feature
- add new contract with non payable method for executing batch calls to ZeroEx
Configuration menu - View commit details
-
Copy full SHA for 7cd9a25 - Browse repository at this point
Copy the full SHA 7cd9a25View commit details -
variables and methods renaming
- renamed batch multiplex calls for better read - define a type in libs and use in the 2 batch multiplex feature contracts and interfaces - use same error behavior as pZEIP1 for uniformity
Configuration menu - View commit details
-
Copy full SHA for 3b2ffa7 - Browse repository at this point
Copy the full SHA 3b2ffa7View commit details