-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Use conan_provider for running conan #3203
Conversation
I've tested with this script:
It seems to work OK, but I'm getting stuck at the same problem as in recent months - jasper refuses to build, looks like a problem with C headers, all errors originate in 'vcruntime_c11_stdatomic.h' or 'jas_thread.h' and there is so many it fills my console scrollback history (I tried both plain cmd and Visual Studio Developer Prompt):
|
@ohlidalp I've updated the jasper pkg, that should fix the build issue with VS 2022 |
It works now, I tested Debug,Release,RelWithDebInfo. I checked https://github.com/RigsOfRods/rigs-of-rods/wiki/Compile-(Windows) and I think it needs just 2 tweaks:
|
@AnotherFoxGuy we should update wiki build instructions after merging this - check my previous post please. |
f2f8f1e
to
5e47ed2
Compare
5e47ed2
to
aaa86af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greenlit for merging when ready. The build instructions can be updated later (minor changes anyway).
Ive already updated those: https://github.com/RigsOfRods/rigs-of-rods/wiki/Compile-(Windows)#running-cmake |
This PR removes the vendored conan profiles and replaces them with the
conan_provider.cmake
scriptWith this PR you no longer have to invoke
conan install
manuallyHow to build on Windows:
cmake . -G"Visual Studio 16 2019" -Bbuild -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=cmake/conan_provider.cmake
Rigs_of_Rods.sln
file in the build folder and switch the config to ReleaseHow to build on Linux:
cmake . -GNinja -DCMAKE_BUILD_TYPE=Release -Bbuild -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=cmake/conan_provider.cmake
ninja