Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

✨ New indicators + minor roi,lookback candles adjustment. #140

Merged
merged 5 commits into from
Sep 23, 2021

Conversation

3ylo
Copy link
Contributor

@3ylo 3ylo commented Sep 12, 2021

This pull request is aiming to improve results by adding tested indicators on the framework.

@Rikj000 Rikj000 self-requested a review September 12, 2021 15:29
@Rikj000 Rikj000 added Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request labels Sep 12, 2021
@Rikj000 Rikj000 added this to the v0.13.0 milestone Sep 12, 2021
@Rikj000 Rikj000 changed the title New indicators + minor roi,lookback candles adjustment. ✨ New indicators + minor roi,lookback candles adjustment. Sep 12, 2021
Optimized imports, Improved weighted signal descriptions, added missing `,`, removed unused plots & indicators, re-added BollingerBand indicator
@Rikj000 Rikj000 linked an issue Sep 12, 2021 that may be closed by this pull request
Copy link
Owner

@Rikj000 Rikj000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! 🎉

I'll fire up a HO on the same random state as my last HO without these changes,
fingers crossed we'll see some nice improvements. 🤞
But I'm quite sure we will! 😄

@Rikj000 Rikj000 added Needs Testing This feature, improvement or bugfix still is in need of testing In Progress This is being worked on labels Sep 12, 2021
@Rikj000 Rikj000 removed In Progress This is being worked on Needs Testing This feature, improvement or bugfix still is in need of testing labels Sep 23, 2021
@Rikj000 Rikj000 merged commit c380a1c into Rikj000:development Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Other & Better indicators!
2 participants