Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the ratings updating logic to preserve ratings that were changed on the same day #59

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

RileyXX
Copy link
Owner

@RileyXX RileyXX commented Jul 29, 2023

  • Modify the ratings updating logic to preserve ratings that were changed on the same day.

Note: In the 1.7.0 release, Trakt ratings took priority for items rated and modified on the same day. However, in version 1.7.1, this behavior was changed to retain the original functionality where ratings are not overwritten. This change ensures that users' updated ratings on IMDB are not accidentally replaced with older Trakt ratings during the next sync.

This issue is due to a limitation in the ratings CSV data provided by IMDB, which only includes the rated date in the Y-M-D format without a specific time.

@RileyXX RileyXX merged commit 802d49d into main Jul 29, 2023
@RileyXX RileyXX deleted the modify-updating-ratings-logic branch July 29, 2023 12:20
@RileyXX RileyXX changed the title Modify updating ratings logic so that ratings made on the same day are not overwritten Modify the ratings updating logic to preserve ratings that were changed on the same day Jul 30, 2023
@RileyXX RileyXX linked an issue Jul 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue preventing re-sync for items with same-day rating updates
1 participant