Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: TEL;TYPE="something-in-quotes" in vcard is not properly recognized #9

Closed
jkischel opened this issue May 7, 2020 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@jkischel
Copy link

jkischel commented May 7, 2020

Currently, Nextcloud does its .vcf export phone numbers like this example:

TEL;TYPE="WORK,VOICE";VALUE=UNKNOWN:+49123456789
which will not be recognized because of the quotes.

In form1.cs, you could change the line 1426 to

switch (type.Replace("\"", ""))

that would do the job, but maybe there is a better place for doing the replace, so I don't add a pull request.

@tryallthethings tryallthethings self-assigned this Oct 19, 2020
@tryallthethings tryallthethings added the enhancement New feature or request label Oct 19, 2020
@tryallthethings
Copy link
Collaborator

I just looked into this (better late than never 😄 ) and I'm able to reproduce this. There's an issue over on the Nextcloud contacts app GitHub: nextcloud/contacts#1107 as the export is not following the RFC.

Meanwhile, I added a configuration option to apply the fix you've mentioned upon .vcf import. Will be available in the next release.

@tryallthethings
Copy link
Collaborator

Please try with https://github.com/Rillke/Contact-Conversion-Wizard/releases/tag/3.5.0.2
There's a setting in the configuration dialogue

@tryallthethings
Copy link
Collaborator

@jkischel Did you get a chance to try this?

@jkischel
Copy link
Author

Sorry for my late reply. With the setting "Apply fix for malformatted .vcf contacts" the import works.

just to mention: this is not an Outlook specific effect. Also some Huawei smart phones and Nextcloud Contacts are exporting quoted descriptors.

However, as this now works, this issue can be closed.

@tryallthethings
Copy link
Collaborator

No worries. Thank you for testing!

@tryallthethings tryallthethings mentioned this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants