Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5.0.2 #15

Merged
merged 5 commits into from
Nov 5, 2020
Merged

3.5.0.2 #15

merged 5 commits into from
Nov 5, 2020

Conversation

tryallthethings
Copy link
Collaborator

No description provided.

+ Added support to import contacts with empty name and / or number from Outlook
* Changed .vcf export to UTF-8 (from UTF-8 BOM)
* Changed support URLs to GitHub page since the original website (software.nv-systems.net) is not reachable anymore.
@tryallthethings
Copy link
Collaborator Author

@Rillke Do you want to review the changes?

Copy link
Owner

@Rillke Rillke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be user-tested by someone in #14, and I can see plenty of improvements. Thanks.

@Rillke
Copy link
Owner

Rillke commented Nov 5, 2020

On the long run, we could move the conversion code out from the forms (e.g. Form1.cs) into separate classes so we can properly unit test im- and export formats and options during CI and add specification to it. Otherwise detecting incompatible changes in the conversion process will be difficult to spot given the increase in options. Thanks for squashing some bugs.

@tryallthethings
Copy link
Collaborator Author

The version was also tested in #9 and #10 😉
Having it as separate classes makes sense although that seems like a major rewrite (especially the export could use some streamlining). Unit tests and CI are things I haven't worked with yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants