RINGUS-71 feat: 멘티가 신청한 멘토링 시간대 변경 기능 구현#59
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a feature for mentees to modify their selected mentoring time slots. Key changes include:
- Addition of a record DTO for editing mentoring times.
- Creation of a new PATCH endpoint in the mentoring controller for changing mentoring times.
- Extension of the domain and service layers with methods to update the mentoring apply times.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/es/princip/ringus/presentation/mentoring/dto/EditMentoringTimeRequest.java | New DTO to capture mentoring ID and updated time slots. |
| src/main/java/es/princip/ringus/presentation/mentoring/MentoringController.java | Added PATCH endpoint for editing mentoring times with session check. |
| src/main/java/es/princip/ringus/domain/mentoring/Mentoring.java | Added a method to update apply times in the domain layer. |
| src/main/java/es/princip/ringus/application/mentoring/MentoringService.java | Introduced transactional service method to modify mentoring times. |
Comments suppressed due to low confidence (2)
src/main/java/es/princip/ringus/application/mentoring/MentoringService.java:58
- [nitpick] The method name 'changeMentoringDate' is inconsistent with the DTO ('EditMentoringTimeRequest') and the domain method ('changeApplyTimes'). Consider renaming it to 'changeMentoringTime' for clarity.
public void changeMentoringDate(EditMentoringTimeRequest request) {
src/main/java/es/princip/ringus/presentation/mentoring/MentoringController.java:39
- [nitpick] The endpoint '/edit/date' does not clearly reflect that it updates mentoring time slots; consider renaming it (e.g., '/edit/time') to match the request DTO and domain context.
@PatchMapping("/edit/date")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타