Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/default transport #12

Merged
merged 8 commits into from
Jan 23, 2022
Merged

Feature/default transport #12

merged 8 commits into from
Jan 23, 2022

Conversation

RyanKung
Copy link
Member

  1. async_trait should be mark as ?Send, for wasm compatibility (ref: Allow async traits rustwasm/wasm-bindgen#2409)
  2. Modified DefaultTransport to
#[derive(Clone)]
pub struct DefaultTransport {
    pub connection: Arc<Mutex<Option<Arc<RTCPeerConnection>>>>,
    pub pending_candidates: Arc<Mutex<Vec<RTCIceCandidate>>>,
}

@RyanKung RyanKung requested a review from Raytlty January 22, 2022 12:00
@RyanKung RyanKung merged commit 9052d2f into master Jan 23, 2022
@Raytlty Raytlty deleted the feature/default_transport branch January 24, 2022 17:09
@Raytlty Raytlty restored the feature/default_transport branch January 24, 2022 17:09
@RyanKung RyanKung deleted the feature/default_transport branch March 17, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants