PWA update sources #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypebright
commented
May 29, 2024
| @@ -18,20 +18,27 @@ const CACHE_NAME = "offline"; | |||
| // Customize this with a different URL if needed. | |||
| const OFFLINE_URL = "offline.html"; | |||
|
|
|||
| async function cacheResources() { | |||
There was a problem hiding this comment.
Note: changed this because easier debugging, and better error messages if something goes wrong!
|
Can be merged once this PR in shinyMobile is merged |
inst/pwa-utils/html/offline.html
Outdated
| // Few tweaks | ||
| if (Framework7.device.standalone) { | ||
| $("html, body").css({ height: "100vh", width: "100vw" }); | ||
| if ($(".appbar").length > 0) { |
There was a problem hiding this comment.
appbar does not exist anymore in Framework7 v8. See here: https://github.com/RinteRface/shinyMobile/blob/master/srcjs/utils/shinyUtils.js#L31. Does it work for you @hypebright. If not, we can leave as is. Let me know.
| new Request("/shiny-javascript-1.8.1.1/shiny.min.js", { cache: "reload" }) | ||
| ]; | ||
|
|
||
| for (const resource of resources) { |
|
@DivadNojnarg - we don't need it, I removed it. I also realised the leading (not trailing... 😅) slash needed to go, this was causing issues when deployed on shinyapps.io for instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DivadNojnarg Since this hard codes the
shinyMobileversion (which is not ideal), would have to wait for the 2.0.1 release (?). See RinteRface/shinyMobile#261