Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show message id when reliable message fails to ack in PendingMessage.TrySend #129

Open
jwlondon98 opened this issue Dec 27, 2023 · 1 comment
Open

Show message id when reliable message fails to ack in PendingMessage.TrySend #129

jwlondon98 opened this issue Dec 27, 2023 · 1 comment
Labels
Feature Request New feature or request Under Consideration It remains unclear whether this feature is necessary or worth implementing

Comments

@jwlondon98
Copy link

It would be useful to have this again. In an older version of riptide the log would print "No ack received for {headerType} message (ID: {messageId} after {sendAttempts}.
@tom-weiland
Copy link
Collaborator

Is it useful though? There's really nothing specific about a message that could cause it to not be delivered, and now if delivery fails the connection is closed so it can only happen once per connection.

I also think that in the future it would be good for Riptide to entirely move away from having message IDs built in as I think that's something that's better for devs to implement/decide how to do themselves.

@tom-weiland tom-weiland added Feature Request New feature or request Under Consideration It remains unclear whether this feature is necessary or worth implementing labels Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature or request Under Consideration It remains unclear whether this feature is necessary or worth implementing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwlondon98 @tom-weiland