update got version #101
Closed
update got version #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejohnso
requested changes
Feb 19, 2018
|
@tejohnso ok, I'll further investigate why my changes didn't work |
|
@tejohnso Finally found why I wasn't able to make it work in launcher. Unfortunately there's an open bug with GOT >8 where useElectronNet causes an error to be thrown. This was reported last December: And that bugs in turn depends upon an open bug in electron. This has been reported on December 2016 and still not fixed: Also unfortunately, the fix we were looking for the installer crash is not available before that version. Thoughts ? |
|
As agreed, I'll work in a workaround directly in launcher with GOT 7 for the time being, and will reopen this PR later with a new GOT version when this particular bug is solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of 'got' that rise-common-electron resulted in an unhandled network error when there are network disconnections or change of network status. Releases 8.x of the library fix that, so I updated. I tested manually the library change and not only the error is now properly caught, but also download process resumes when there's again connectivity.
Release 8 of GOT ( https://github.com/sindresorhus/got/releases ) says it changes the default value of useElectronNet from true to false, but when I tried to preset it in previous PR it failed on launcher integration and manual tests. Leaving the code unchanged seems to work though, so I'm submitting this PR instead without those changes.