Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added contrast to text and background #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OluJoseph
Copy link

also added some paddings to the sections to make it look a little bit better

@OluJoseph
Copy link
Author

@Rishit30G

@Rishit30G
Copy link
Owner

Rishit30G commented Oct 23, 2021

Hey!
Thanks for contributing 👍🏻
Can you please deploy the website online, so that I can see the changes clearly

@OluJoseph
Copy link
Author

@Rishit30G
Copy link
Owner

Its getting too dark on scrolling and is not looking that great,
Try a better UI design, take inspiration from Dribbble
Keep Contributing! 🏆

@Rishit30G Rishit30G added the enhancement New feature or request label Oct 24, 2021
Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This HTML snippet is a template for a modern, responsive personal portfolio website. It contains multiple sections tailored to showcase a person's skills, services, and contact information. Here's a detailed review:


Strengths

  1. Clear Structure:
    The code is well-organized with clearly defined sections (home, about, services, skills, contact), making it easy to navigate and maintain.
  2. Responsive Design Elements:
    The use of div containers like max-width and backdrop ensures that the layout is adaptable to various screen sizes.
  3. Engaging Features:
    o Typing animations (typing, typing-2) in the home and about sections add a dynamic element.
    o Icon usage (fas fa-laptop-code, etc.) enhances the visual appeal of the services and skills sections.
  4. User Interaction:
    The contact form is functional and provides fields for users to send messages. The placeholder text guides users effectively.
  5. Customizable Placeholders:
    The placeholders (YOUR NAME, YOUR EMAIL, etc.) make the template versatile for personal branding.
  6. Design Consistency:
    The use of a "backdrop" and consistent layout styles gives the website a cohesive look.

Suggestions for Improvement

  1. Content Customization:
    Replace lorem ipsum text with meaningful content that reflects the user's personality, services, and skills.
  2. Enhance Accessibility:
    o Add aria-label attributes to icons for better screen reader compatibility.
    o Use semantic tags (header, main, article) for improved accessibility.
  3. Optimize Images:
    o Provide alt attributes with descriptive text for all images.
    o Ensure image sizes are optimized for faster loading.
  4. Improve the Contact Form:
    o Add basic validation messages for better user feedback.
    o Use reCAPTCHA or similar tools to reduce spam.
  5. Styling and Animations:
    o Include CSS transitions for smoother interactions, like button hover effects.
    o Ensure dark mode compatibility for modern aesthetics.
  6. Performance Optimization:
    o Minimize the use of inline styles and scripts.
    o Use a CDN for assets like icons and libraries to improve loading speed.
  7. Footer Content:
    The footer section is incomplete. Add links to social media profiles, copyright notices, or other relevant information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants