Fix FirebaseUser and userModel state mismatch issue on app launch (iOS). #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix userModel state issue on app launch (iOS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using current firebase package versions, if you stopped the app while you were logged in, you would end up with a null userModel but active user session on firebase, breaking the app flow.
The problem was on line 55 - you don't need to check for userModel.
I also added a bit of cleanup for error and loading states.
Tested on:
firebase_core: ^2.10.0
cloud_firestore: ^4.5.3
firebase_auth: ^4.4.2