Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBET Tweaks and Refinements - 8/16/2021 #381

Closed
10 of 13 tasks
joewheaton opened this issue Aug 17, 2021 · 6 comments
Closed
10 of 13 tasks

VBET Tweaks and Refinements - 8/16/2021 #381

joewheaton opened this issue Aug 17, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@joewheaton
Copy link
Contributor

joewheaton commented Aug 17, 2021

On 8/16/21 @philipbaileynar, @shelbysawyer, @lauren-herbine and @joewheaton discussed latest version of VBET. This feedback was based on progress in https://github.com/Riverscapes/RiverscapesData/issues/19 and from #369.

  • @philipbaileynar please edit this ticket to get the five next steps we talked about queued up and tracked.

My recollection was there were five things you wrote down (please elaborate as you and @KellyMWhitehead need to):

  • 1. Add new cookie cutter feature classes:
    • active_floodplain (vbet_80 with channel areas cut out)
    • inactive_floodplain (vbet_80 with vbet_68 cut out)
  • 2. Remove the current VBET polygon sanitization. The final VBET outputs for 68 and 80 will be pixelated. The only curation will be to:
    • delete polygon features with area less than or equal to 10 pixels (i.e. 100m^2)
    • delete polygon donuts with area less than or equal to 10 pixels
  • 3. Add the input channel area feature class to the VBET output GeoPackage and call vbet_channel_area
  • 4. Add centerline code back in to VBET. This is just for review at this stage. It's not an official VBET output for now.
  • 5. We live with existing segmentation!

Once these above tweaks are done, please have @KellyMWhitehead

@philipbaileynar
Copy link
Contributor

Note that if we stick with the pixelated vectors then note that channel area vector will be smooth while 80 and 68 will be jagged. This affects the active floodplain feature class which will have a smooth donut and jagged exterior.

@joewheaton
Copy link
Contributor Author

Thanks a ton @philipbaileynar for the clarifications and fixes above. Perfect.

Note that if we stick with the pixelated vectors then note that channel area vector will be smooth while 80 and 68 will be jagged. This affects the active floodplain feature class which will have a smooth donut and jagged exterior.

Understood and happy with that.

KellyMWhitehead added a commit that referenced this issue Aug 19, 2021
@KellyMWhitehead
Copy link
Contributor

All changes were made except for adding the centerline. The rasterized edges of the new polygons are throwing off the centerline method (the increased number of vertices is adding several hours to the processing time and the jagged edges are producing bad results). Will investigate...

@philipbaileynar
Copy link
Contributor

I approve of the decision to put centerlines on hold for now. Kelly, please close this issue and proceed to run the MHFD HUC for review by @joewheaton @lauren-herbine and @shelbysawyer

@joewheaton
Copy link
Contributor Author

Thanks for updates guys. @philipbaileynar lets discuss a strategy for the centerlines. I will start a new ticket to explore this.

MattReimer pushed a commit that referenced this issue Sep 3, 2021
MattReimer pushed a commit that referenced this issue Sep 3, 2021
@joewheaton
Copy link
Contributor Author

The two outstanding tasks here are already queued up in:
https://github.com/Riverscapes/RiverscapesData/issues/24

Therefore I am closing this.

MattReimer pushed a commit that referenced this issue Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants