Use std::string inside BwString #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpp
reviewed
May 9, 2017
src/Player.cpp
Outdated
| @@ -5,6 +5,12 @@ | |||
| #include <BWAPI/TechType.h> | |||
| #include <BWAPI/Color.h> | |||
|
|
|||
| #include <Types.h> | |||
kpp
requested changes
May 9, 2017
src/String.cpp
Outdated
| } | ||
|
|
||
| void String_release(String* self) { | ||
| delete[] self->data; | ||
| assert(self); |
There was a problem hiding this comment.
Семантика этой проверки не в том, что «delete надо вызывать на ненулевом указателе», а в том, что «по логике программы сюда должны передать ненулевой указатель. Если он нулевой, что-то сильно не так в вызывающем коде».
То есть, я тут проверяю контракт на сам вызов.
kpp
force-pushed
the
master
branch
2 times, most recently
from
c7cd52e to
118d9f1
Compare
kpp
approved these changes
May 11, 2017
kpp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.