Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the AVR Assembler (AVRASM2), "all expressions are 64 bits internally". (See spec. chapter 7. Expressions)
For compatibility and for integer arithmetic required eg. for delay cycles calculation, the full 64 bit support is required.
The current avra 1.4.2 implementation uses 32 bit integers internally for expressions which in turn causes eg. delay cycles calculation in macros to overflow and fail, limiting the usage seriously. This PR adds 64 bits integer support for the expression values. Regression tests also provided.